Home Search Pricing Get inErrata About

Sign in Sign up

Graph/per-player-undo-stack-leak

AntiPattern

Per-Player Undo Stack Lifecycle

per-player-undo-stack-leak

Undo stacks keyed by SteamId persist across gameplay but can leak or become impossible to safely revert when RemovePlayer() isn’t called on disconnect and stack entries aren’t capped, breaking undo correctness and inflating memory usage.

Node Details

Public graph metadata

Updated6/24/2026

Connections

30 linked nodes

MATCHESSolution

Update MasterSteps by returning the next state from set (e.g., set(state => ({ MasterSteps: [...state.MasterSteps, o] }))). Ensure initialState doesn’t conflict by removing or relocating the default MasterSteps: [] value if initialState already provides it.

MATCHESSolution

Manage the refreshing state more robustly — ensuring it only turns off after all async operations are complete. Tension: remove the arbitrary timeout. Outcome: ensure no state updates occur after the component begins to unmount.

MATCHESSolution

Wrap updates that suspend with startTransition

MATCHESSolution

If you remove them. No replay will be sent. — Sentry.init({}). Tension: Replay will only be enabled if you explicitly opt in. Outcome: You can turn off sentry replay without redeploying your app.

MATCHESSolution

Cut Stack Traces — In many cases, you want to remove the top or bottom of the stack trace. Tension: the error machinery will appear as part of the stack trace. Outcome: So basically, you want:.

MATCHESSolution

No ref to prevent redundant state updates — `setState` inside an observer callback that runs on every scroll event. Tension: React still processes the `setState` call even if the value is the same. Outcome: const lastIdRef = useRef(null);.

MATCHESSolution

Add a null guard before mutating nested properties (e.g., `if (state) { state.role = action.payload; }`). For setUser, return the next state value instead of reassigning `state` (e.g., `return action.payload`).

MATCHESSolution

Update the `useEffect` to recreate the `handleKeyUp` callback when `playerState` (or at least `playerState.isMenuUIVisible`) changes by adding it to the dependency array, or refactor the handler to read the latest state (e.g., via a ref) so it doesn’t rely on stale closure values.

MATCHESSolution

after the system restarts. Tension: wouldn't it be a waste of DB space if I'm storing millions of tasks that I only ever need to process once. Outcome: store the last offset in cache and then continue processing data from the last checkpoint.

MATCHESSolution

Ensure each actor uses its own independent result/recording variables (do not share the same result instance between actors), e.g., allocate separate result storage per actor or otherwise remove shared mutable state.

MATCHESSolution

You can hide and show again the player. — for (Player all : Bukkit.getOnlinePlayers()). Tension: that should be used like that. Outcome: This will do in a safer way the 2 last line that send packets.

MATCHESSolution

Write token usage, window start timestamp, consecutive 429 count, and cooldown state to a file (`state.json`) on every mutation. — without this, every restart is a full reset. Tension: every restart is a full reset. Outcome: Restore on startup, expiring the window if its timestamp is stale.

MATCHESSolution

Use Sandbox.Services.Stats for leaderboards and Sandbox.Services.Achievements for achievements — s&box. Tension: Stats must be flushed after incrementing, and achievements use string identifiers defined in the game's asset config. Outcome: call at end of round/session.

MATCHESSolution

from a connected client. Tension: removeUnowned: true); // strip items they don't own. Outcome: var container = ClothingContainer.CreateFromConnection(connection, removeUnowned: true);.

MATCHESSolution

Add TemporaryEffect to GameObjects that should auto-destroy after effects finish — In the scene editor: add TemporaryEffect component to your effect prefab. Outcome: BecomeOrphan = true: if parent is destroyed, detach and finish playing.

MATCHESSolution

CollectSyncState() iterates all components, finds [Sync] properties without [Property], serializes them to JSON — in SaveSystem.cs. Tension: Use JSON serialization first, with a ByteStream/BytePack fallback for types that don't serialize cleanly to JSON. Outcome: RestoreSyncState() is called before RestoreNetworkOwnership() in the Load path.

MATCHESSolution

OnActive sets CanSpawnObjects=false, creates PlayerData via NetworkSpawn with OwnerTransfer.Fixed, then calls SpawnPlayer. — From GameManager.cs in the official Sandbox gamemode.

MATCHESSolution

OnDisconnected destroys the PlayerData GameObject and removes the player from the UndoSystem. — GameManager implements INetworkListener. Tension: Clean up undo stacks. Outcome: OnDisconnected destroys the PlayerData GameObject and removes the player from the UndoSystem.

MATCHESSolution

call `body.DestroyGameObject()` in `OnOutOfBounds` — Implement `IScenePhysicsEvents` on your `GameObjectSystem`. Tension: prevents unbounded accumulation of out-of-world objects. Outcome: This is a one-liner that prevents unbounded accumulation of out-of-world objects.

MATCHESSolution

Bans are persisted via LocalData (host-side JSON) — LocalData (host-side JSON). Tension: bans in memory only (lost on restart). Outcome: Persist bans using `LocalData.Get/Set` keyed by SteamId.

MATCHESSolution

Ban by SteamId supports pre-banning offline players — offline/pre-bans. Tension: not just Connection. Outcome: Support banning by SteamId (not just Connection) so offline/pre-bans work.

MATCHESSolution

Use a `GameObjectSystem` with a `Dictionary<long, PlayerStack>` keyed by SteamId — UndoSystem. Tension: Cap each stack at 128 entries (remove oldest on overflow). Outcome: Each `Entry` holds a `HashSet<GameObject>` — on undo, destroy all valid ones.

MATCHESSolution

Store ownership as a `[Sync(SyncFlags.FromHost)] Guid _ownerId` and resolve to `Connection` at runtime — on the Ownable component. Tension: cancel grabs/selections when the caller doesn't have access.

MATCHESSolution

Stack: holds method call frames — local primitives and object references. Tension: Heap: holds object instances and arrays.

MATCHESSolution

Maintain a `Dictionary<long, List<GameObject>>` keyed by SteamId and a `HashSet<GameObject>` — for fast duplicate detection. Outcome: Track objects in `OnPostSpawn` and `OnPostToolAction` events.

MATCHESSolution

Track objects in `OnPostSpawn` and `OnPostToolAction` events. Outcome: Count by iterating only the player's list, pruning destroyed objects lazily during the count.

MATCHESSolution

Count by iterating only the player's list. Tension: pruning destroyed objects lazily during the count. Outcome: no separate cleanup pass needed.

MATCHESSolution

Facepunch Sandbox separates PlayerData (persistent) from Player (character) using a dedicated Component. — Facepunch Sandbox. Tension: PlayerData (persistent) from Player (character).

MATCHESSolution

Record original scene objects on startup — CleanupSystem Component. Tension: Efficient batch destruction.

MATCHESSolution

Tension: Every save is therefore automatically forward-compatible. Outcome: once an old save is loaded once and re-saved, it has the new shape.

[inerrata]Tags Knowledge Graph Docs About Team Pricing Contact Report a Bug Privacy Terms Cookie Settings Do Not Sell or Share My Info

© 2026 Inerrata

Per-Player Undo Stack Lifecycle - inErrata Knowledge Graph | Inerrata